Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix utils to not require TENANT_USE_ASGIREF to be defined in the host django project #206

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Fix utils to not require TENANT_USE_ASGIREF to be defined in the host django project #206

merged 2 commits into from
Dec 18, 2023

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Dec 14, 2023 •
edited
Loading

Most projects using django-multitenant wont have TENANT_USE_ASGIREF defined as its a new feature.
They also shouldnt be required to add it... should just be treated as False if missing.

This is an issue that was introduced by #198

Note that this will also resolve #205 issues

@ekampf
Copy link
Contributor Author

ekampf commented Dec 14, 2023

FYI @gurkanindibay this is an issue thats breaking everyone installing the new 4.1.0

@gurkanindibay
Copy link
Contributor

FYI @gurkanindibay this is an issue thats breaking everyone installing the new 4.1.0

@ekampf Thanks for the heads up. I'm checking

@gurkanindibay
Copy link
Contributor

@ekampf could you check the errors

Thanks

@ekampf
Copy link
Contributor Author

ekampf commented Dec 15, 2023

@microsoft-github-policy-service agree

@ekampf
Copy link
Contributor Author

ekampf commented Dec 15, 2023

@microsoft-github-policy-service agree company="twingate"

@ekampf
Copy link
Contributor Author

ekampf commented Dec 15, 2023

@gurkanindibay tests fixed

@codecov Codecov
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30e3238) 100.00% compared to head (42cef30) 100.00%.
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #206   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         1193      1240   +47     
=========================================
+ Hits          1193      1240   +47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gurkanindibay gurkanindibay merged commit 44b4e86 into citusdata:main Dec 18, 2023
51 checks passed
@gurkanindibay
Copy link
Contributor

@ekampf I released v4.1.1 with your PR. Could you check?
Thanks

@ekampf ekampf deleted the feature/fix-asgiref branch December 18, 2023 17:13
@ekampf
Copy link
Contributor Author

ekampf commented Dec 18, 2023

@gurkanindibay thanks! confirming it works

@gurkanindibay
Copy link
Contributor

@ekampf thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurkanindibay gurkanindibay gurkanindibay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release 4.1.0 overwrote 4.0.0 wheel
2 participants
@ekampf @gurkanindibay